Feat/add tag to log api #92
Conversation
|
|
||
| export async function POST( | ||
| req: Request, | ||
| { params }: { params: { id: string } }, |
There was a problem hiding this comment.
Might be nice for readability for this to be typed outside e.g type QueryParams = { id : string } and then you could us it like { params : QueryParams}
There was a problem hiding this comment.
but maybe thats just my preference :P
| req: Request, | ||
| { params }: { params: { id: string } }, | ||
| ) { | ||
| const json = await req.json(); |
There was a problem hiding this comment.
Can .json here throw? What happens?
| { params }: { params: { id: string } }, | ||
| ) { | ||
| const json = await req.json(); | ||
| const tagId = json.tagId; |
There was a problem hiding this comment.
| const tagId = json.tagId; | |
| const { tagId } = json; |
| const json = await req.json(); | ||
| const tagId = json.tagId; | ||
| try { | ||
| await LogsData.connectTag(params.id, tagId); |
There was a problem hiding this comment.
Took me a while to work out what this meant - naming is tough :( Perhaps being more explicit with something like connectTagToLog is worth it? Not sure
| try { | ||
| await LogsData.connectTag(params.id, tagId); | ||
| } catch (error) { | ||
| return NextResponse.json({ error: error }, { status: 500 }); |
There was a problem hiding this comment.
If you don't catch it, would this not be the default behaviour?
There was a problem hiding this comment.
No, it only return a response with status 500, but no error message. It doesn't seem like an error message shows in the console either.
https://trello.com/c/gaGfCBt8/267-2-aadev-when-i-make-an-api-call-to-link-an-existing-tag-with-a-log-i-can-see-it-in-the-database